Skip to content

build and push images based on samba-server 'devbuilds-centos-amd64' #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

build and push images based on samba-server 'devbuilds-centos-amd64' #27

merged 3 commits into from
Jul 17, 2025

Conversation

synarete
Copy link
Collaborator

@synarete synarete commented Jul 16, 2025 •
edited
Loading

Ensure smbmetrics uses same base image upstream ceph; that is, devbuilds-centos-amd64

@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Jul 16, 2025 •
edited
Loading

My suggestion: let's add a new build arg to the Container file that defaults to the current base image value. With the new base image build argument, we can configure the makefile and CI to generate samba-metrics:$TAG images where tag matches the tag on the parent samba-server images.

How does that sound?

@synarete
Copy link
Collaborator Author

My suggestion: let's add a new build arg to the Container file that defaults to the current base image value. With the new base image build argument, we can configure the makefile and CI to generate samba-metrics:$TAG images where tag matches the tag on the parent samba-server images.

How does that sound?

Fair enough. Will fix.

@synarete synarete force-pushed the ss-base-image-sambe-server-nightly branch from 9f7ace4 to 1842cf2 Compare July 16, 2025 15:02
@synarete synarete changed the title image: use 'samba-server:nightly' as base image build and push images based on samba-server 'devbuilds-centos-amd64' Jul 16, 2025
@synarete synarete force-pushed the ss-base-image-sambe-server-nightly branch from 1842cf2 to dd5d42c Compare July 16, 2025 15:35
anoopcs9
anoopcs9 reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, other than the typo in the commit message for image: allow passing explicit samba base-imag (s/smabe/samba) see below for some minor comments.

synarete added 3 commits July 17, 2025 13:45
@synarete
image: allow passing explicit samba base-image
c57f711 
The smbmetrics image is based on one of multiple samba-server images.
Allow user to define an explicit base-image, with latest as default.

Signed-off-by: Shachar Sharon <[email protected]>
@synarete
makefile: allow define base-image via command-line
38bf34a 
Allow user to define base image url and tag via command line args.

Signed-off-by: Shachar Sharon <[email protected]>
@synarete
workflows: build and push devbuilds images
644d925 
Align smbmetrics with main image tag which is consumed by upstream Ceph
project ('devbuilds-centos-amd64') in order to avoid lagging behind.

Signed-off-by: Shachar Sharon <[email protected]>
@synarete synarete force-pushed the ss-base-image-sambe-server-nightly branch from dd5d42c to 644d925 Compare July 17, 2025 10:56
@synarete
Copy link
Collaborator Author

lgtm, other than the typo in the commit message for image: allow passing explicit samba base-imag (s/smabe/samba) see below for some minor comments.

Fixed.

anoopcs9
anoopcs9 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

phlogistonjohn
phlogistonjohn approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@synarete synarete merged commit 1bae596 into samba-in-kubernetes:main Jul 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

+1 more reviewer

@anoopcs9 anoopcs9 anoopcs9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@synarete @phlogistonjohn @anoopcs9