Update build tools #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With go1.25, there's a breaking change[1] from golang.org/x/tools pulled in by controller tools for which a fix is available in either v0.24.1 (and above) or v0.25.1 (and above). This minimum version of golang.org/x/tools is only included from controller tools v0.16.4. We make use of this opportunity to fetch the latest version. [1] golang/go#74462 Signed-off-by: Shachar Sharon <[email protected]>
With go1.24 as a oldstable release, it is recommended to use a gosec version supporting go1.24 (from v2.22.1[1]) to avoid any unexpected errors. Additionally fix/ignore the newly reported gosec errors. [1] https://github.com/securego/gosec/releases/tag/v2.22.1 Signed-off-by: Shachar Sharon <[email protected]>
anoopcs9
reviewed
Sep 25, 2025
Originally, I though of making it in two steps: update (same as in samba-operator) and then followup with cleanup PR. Thinking of it again, it makes no sense: will just do a proper cleanup right with in this PR. |
|
Closing this PR -- need to re-think how to this cleanup properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align build tools with samba-operator (samba-in-kubernetes/samba-operator#365)