Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can you explain the change please? In what case is it necessary? |
|
After more in-depth testing, I noticed that the previous set of queries isn't working correctly. I'll make a correction and explain the purpose. The PrometheusTargetMissing rule spams when all targets are missing, so it's advisable to prevent it from evaluating when this happens. For this case, we have the PrometheusAllTargetsMissing rule. But this will only work when both rules are used, and I use both. I think this should be noted. |
|
Ok, i'm going to add a short comment to explain this behavior EDIT: I made the change in the right file. Files under |
Tune targets missing rules, to exlude dublicating alerts, when job has only one target.