Skip to content

tune Targets Missing rules#497

Merged
samber merged 3 commits intosamber:masterfrom
dxrayz:master
Feb 21, 2026
Merged

tune Targets Missing rules#497
samber merged 3 commits intosamber:masterfrom
dxrayz:master

Conversation

@dxrayz
Copy link
Contributor

@dxrayz dxrayz commented Feb 13, 2026

Tune targets missing rules, to exlude dublicating alerts, when job has only one target.

@samber samber requested a review from Copilot February 14, 2026 00:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samber
Copy link
Owner

samber commented Feb 14, 2026

Can you explain the change please?

In what case is it necessary?

@dxrayz
Copy link
Contributor Author

dxrayz commented Feb 14, 2026

After more in-depth testing, I noticed that the previous set of queries isn't working correctly. I'll make a correction and explain the purpose. The PrometheusTargetMissing rule spams when all targets are missing, so it's advisable to prevent it from evaluating when this happens. For this case, we have the PrometheusAllTargetsMissing rule. But this will only work when both rules are used, and I use both. I think this should be noted.

@samber
Copy link
Owner

samber commented Feb 21, 2026

Ok, i'm going to add a short comment to explain this behavior

EDIT: I made the change in the right file. Files under dist/ are generated

@samber samber merged commit e60601f into samber:master Feb 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants