Merge pull request rubocop#1467 from Earlopain/less-rails-extensions

Don't load the active_support `blank` core extension

Author: koic

lib/rubocop-rails.rb

@@ -3,7 +3,6 @@
 require 'rubocop'
 require 'rack/utils'
 require 'active_support/inflector'
-require 'active_support/core_ext/object/blank'
 
 require_relative 'rubocop/rails'
 require_relative 'rubocop/rails/version'

lib/rubocop/cop/mixin/database_type_resolvable.rb

@@ -29,8 +29,8 @@ def database_from_yaml
       end
 
       def database_from_env
-        url = ENV['DATABASE_URL'].presence
-        return unless url
+        url = ENV.fetch('DATABASE_URL', '')
+        return if url.blank?
 
         case url
         when %r{\A(mysql2|trilogy)://}

lib/rubocop/cop/rails/reflection_class_name.rb

@@ -76,7 +76,7 @@ def reflection_class_value?(class_value)
         def autocorrect(corrector, class_config)
           class_value = class_config.value
           replacement = const_or_string(class_value)
-          return unless replacement.present?
+          return unless replacement
 
           corrector.replace(class_value, replacement.source.inspect)
         end

lib/rubocop/cop/rails/schema_comment.rb

@@ -39,7 +39,7 @@ class SchemaComment < Base
 
         # @!method comment_present?(node)
         def_node_matcher :comment_present?, <<~PATTERN
-          (hash <(pair {(sym :comment) (str "comment")} (_ [present?])) ...>)
+          (hash <(pair {(sym :comment) (str "comment")} (_ !blank?)) ...>)
         PATTERN
 
         # @!method add_column?(node)