Skip to content

Create learncpp.com.css #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Create learncpp.com.css #1675

wants to merge 11 commits into from

Conversation

@kauht
Copy link

@kauht kauht commented Aug 6, 2025

added styles for learncpp.com

@sameerasw
Copy link
Owner

sameerasw commented Aug 14, 2025

There are some harcoded values in the css, Can you make sure that does not break the light/ dark themes of the website?

@kauht
Copy link
Author

kauht commented Aug 15, 2025

There are some harcoded values in the css, Can you make sure that does not break the light/ dark themes of the website?

The website doesn't actually have a dark mode option. It's only light mode and they suggest using dark reader for dark mode.

@sameerasw
Copy link
Owner

sameerasw commented Aug 20, 2025

There are some harcoded values in the css, Can you make sure that does not break the light/ dark themes of the website?

The website doesn't actually have a dark mode option. It's only light mode and they suggest using dark reader for dark mode.

Yes but hardcoded values will not get overridden by darkreader... But the website theme is written to be a dark theme. It doesn't adapt tot he browser's theme so the light theme now is unusable.

CleanShot 2025-08-20 at 6  22 08@2x

@sameerasw sameerasw marked this pull request as draft August 20, 2025 12:53
@sameerasw sameerasw moved this from Pending to In progress in Theme requests and issues Aug 20, 2025
@kauht kauht marked this pull request as ready for review August 23, 2025 08:05
@sameerasw
Copy link
Owner

sameerasw commented Sep 13, 2025

Still broken on light theme, we do not have to add a custom dark theme as literally the website developer gave up on it. Just need to adapt darkreader

CleanShot 2025-09-13 at 5  19 31@2x

@sameerasw sameerasw marked this pull request as draft September 13, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kauht kauht

Labels

Theme

Projects

Theme requests and issues
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kauht @sameerasw