Skip to content

Conversation

@mrinmoyin
Copy link
Contributor

@mrinmoyin mrinmoyin commented Aug 6, 2025

Simplify and rewrite.

Added features

  • Fix Overlapping Header
  • Immersive Popup
  • Animations

Removed features

  • Transparent header
  • Transparent video background

With great respect, it has taken a lot of hard work to develop the features we currently have. However, when most of the features are turned on, it feels like using an unofficial client. On the other hand, if I turn off most of the features, there ends up being a lot of overlap. So I’ve tried to keep it simple and as similar as possible except for the background.

@sameerasw
Copy link
Owner

Unfortunately this is not a good idea as some features actually were requested by users. What i will recommend is to keep a fork of this and deploy it as a github page or so, then use that generated styles.json file instead of this repository's official one. You should still be able to keep the rest of the styles up-to-date with occasional git pulls from the main to the fork.

One of the reasons I added this so users can pick their flavors. You don't even have to use transparency, You may completely remove transparency and replace with nord or catpuccin theme and this will work just fine :)

I don't think removing what's added without the users requesting to do so is a good idea.

CleanShot 2025-08-07 at 9  54 45@2x

@mrinmoyin
Copy link
Contributor Author

mrinmoyin commented Aug 7, 2025

Unfortunately this is not a good idea as some features actually were requested by users. What i will recommend is to keep a fork of this and deploy it as a github page or so, then use that generated styles.json file instead of this repository's official one. You should still be able to keep the rest of the styles up-to-date with occasional git pulls from the main to the fork.

One of the reasons I added this so users can pick their flavors. You don't even have to use transparency, You may completely remove transparency and replace with nord or catpuccin theme and this will work just fine :)

I don't think removing what's added without the users requesting to do so is a good idea.

We can keep most of those features as it is except those we don't need anymore ex. transparent header.

btw iam pulling in the styles.json from the raw githubusercontent for testing use. i didn't want to keep a separate repo for this because i have to maintain the whole repo then.

made chips look as default
@sameerasw
Copy link
Owner

That is understandable but I still am not sure on removing like almost all the features of the website, Might even be worth questioning the community maybe with a discussion or so.

@mrinmoyin
Copy link
Contributor Author

That is understandable but I still am not sure on removing like almost all the features of the website, Might even be worth questioning the community maybe with a discussion or so.

Iam currently working on it to keep as much features as possible while those can be toggled without breaking other features. So you can make this pr draft for now and will try to initiate a discussion as there is some known feature conflicts.

Currently trying to fix the player in fullscreen mode.

liberated "Animations" and some other fixes
made natural "mini guide" looks similar to artificial "mini guide" and animated it.
fixed fullscreen player
@mrinmoyin
Copy link
Contributor Author

Now, it can be reviewed.

Still i can't find any walkaround for the app drawer and mini guide feature conflict.

some transparency fixes
fixed skeleton rendering for "fix new feed layout" feature
@sameerasw
Copy link
Owner

A lot to be still fixed as most of the animations are now gone. Because the theme has heavy modifications, without animations they look not healthy for UX or accessibility. Also the zen view is broken as the header space is still being occupied. And there were quite some more issues too...

I still think if we modified the existing theme to be more compact with the code, it will be much easier to migrate and also will have less changes to break.

image

@sameerasw sameerasw marked this pull request as draft August 20, 2025 12:49
@sameerasw sameerasw added the enhancement New feature or request label Aug 20, 2025
fixed broken "theater: zen view" feature
brought forgotten animations back.
@mrinmoyin
Copy link
Contributor Author

mrinmoyin commented Aug 20, 2025

Is it okay to have the same transition effect for everything?

fixed "yt-theater: zen view" feature
@mrinmoyin mrinmoyin marked this pull request as ready for review August 24, 2025 16:41
fixed immersive search transition
fixed app drawer background when mini guide feature is disabled
fixed overlapping channel header
fixed caption background transparency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

2 participants