-
Notifications
You must be signed in to change notification settings - Fork 35
Support of React 19 - WIP #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Nice! What is the status on this? |
|
I don't think we want to change peer dependencies, users running react16 + 18 should still be able to use this library. Unless there is a change within the library that requires react19 that I am not seeing. |
|
Bump, Library unusable with React 19 |
|
Running into this issue as well, unusable library on React 19 |
|
Thanks for this! I'm running this as a local package and it does seem to be working with React 19. However, it adds 349 packages on install... is that to be expected? |
|
Am I missing something or couldn't a new major npm version be created that would support React 19? React 18 and prior users would continue to use the current major version. Any downside to that? |
|
Hi! Any chance of an update to support React 19? Would really appreciate it! 🙏 |
| "peerDependencies": { | ||
| "react": ">=16.2.0", | ||
| "react-dom": ">=16.2.0" | ||
| "react": ">=19.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will restrict users to only use version 19, we should keep it at >=16.2.0 since this package will still work with lower versions, from what I can see there isn't any react19 specific features that will break this in lower versions.
That PR needs to be cleaned.
Credits to @eadwinCode