Skip to content

Conversation

@hannotauber
Copy link

At some point ujson was used for json loads #383 but it does not seem to be the case any more. This code has be lost. I do in v1.0.16

[hannotauber@toolbox python-binance]$ grep -r ujson
docs/changelog.rst:- Stock json lib to ujson (https://github.com/sammchardy/python-binance/pull/383)
requirements.txt:ujson
setup.py:        'requests', 'six', 'dateparser', 'aiohttp', 'ujson', 'websockets'

I am more confident with the work and benchmark results of orjson along with the licensing which comes with Apache 2 and MIT licenses.

@sammchardy
Copy link
Owner

@hannotauber orjson also requires Rust and can't be installed under some interpreters.

A better option would be allowing to pass a json serializer into the Client so that any could be used.

@carlosmiei
Copy link
Collaborator

@hannotauber It was implemented here: #1479 Now you just need to have orjson installed and python-binance will pick it up automatically.

@carlosmiei carlosmiei closed this Nov 22, 2024
@carlosmiei carlosmiei self-requested a review November 22, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants