Skip to content

fix: threaded_stream #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlosmiei merged 17 commits into from
Dec 30, 2024
Merged

fix: threaded_stream #1463

carlosmiei merged 17 commits into from
Dec 30, 2024

Conversation

@pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Oct 29, 2024 •
edited
Loading

  • Add tests for threaded stream
  • Add support for async callback
  • improve closing

@pcriadoperez pcriadoperez self-assigned this Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Coverage Status

coverage: 68.153% (+0.2%) from 67.986%
when pulling ff2ff2e on pcriadoperez:test-thread-stream
into 10f3986 on sammchardy:master.

pcriadoperez
pcriadoperez commented Oct 30, 2024
View reviewed changes
@pcriadoperez pcriadoperez reopened this Oct 30, 2024
@pcriadoperez pcriadoperez reopened this Oct 30, 2024
@carlosmiei carlosmiei closed this Oct 30, 2024
@carlosmiei carlosmiei reopened this Oct 30, 2024
carlosmiei
carlosmiei reviewed Oct 30, 2024
View reviewed changes
@carlosmiei
Copy link
Collaborator

carlosmiei commented Oct 30, 2024

hum @pcriadoperez this test is failing consistently
image

@carlosmiei carlosmiei closed this Oct 31, 2024
@carlosmiei carlosmiei reopened this Oct 31, 2024
@pcriadoperez pcriadoperez changed the title chore: add more test_threaded_stream tests fix: threaded_stream Dec 2, 2024
@carlosmiei
Copy link
Collaborator

carlosmiei commented Dec 2, 2024

@pcriadoperez I'm assuming this PR does not apply anymore, but please let me know if otherwise

@carlosmiei carlosmiei closed this Dec 2, 2024
@pcriadoperez pcriadoperez reopened this Dec 8, 2024
@pcriadoperez pcriadoperez marked this pull request as draft December 8, 2024 16:15
@pcriadoperez pcriadoperez reopened this Dec 9, 2024
@pcriadoperez pcriadoperez reopened this Dec 11, 2024
@pcriadoperez pcriadoperez marked this pull request as ready for review December 11, 2024 04:40
@carlosmiei carlosmiei merged commit 2e909c9 into sammchardy:master Dec 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmiei carlosmiei Awaiting requested review from carlosmiei carlosmiei is a code owner

Assignees

@pcriadoperez pcriadoperez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcriadoperez @coveralls @carlosmiei