Skip to content

Conversation

@pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Nov 30, 2024

  • Remove CANCEL read_loop error log. This is not an error as the loop is closed before intentionally.
  • Change log debug errors of errors to errors
  • Fix error type for when message queue is full
  • Return errors to user
  • Add tests for ReconnectingWebsocket.py
  • Fixes that if first connect fails it would not throw and let the user wait indefinetly
  • Improves error handling passing to user error type for different scenarios
  • Update docs
  • Add websockets_proxy to requirements for python 3.8+

@coveralls
Copy link

coveralls commented Nov 30, 2024

Coverage Status

coverage: 68.112% (+0.6%) from 67.499%
when pulling a3f1081 on pcriadoperez:logs
into 39d7f7a on sammchardy:master.

@pcriadoperez pcriadoperez changed the title fix: adjust logs in reconnecting websocket fix: reconnecting websocket Dec 1, 2024
@pcriadoperez pcriadoperez marked this pull request as ready for review December 1, 2024 22:57
@carlosmiei carlosmiei merged commit 39bbd87 into sammchardy:master Dec 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants