Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions binance/async_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,23 @@ async def _request(
uri = f"{uri}?{kwargs['params']}"
kwargs.pop("params")

data = kwargs.get("data")
if data is not None:
del kwargs["data"]

if signed and self.PRIVATE_KEY and data: # handle issues with signing using eddsa/rsa and POST requests
dict_data = Client.convert_to_dict(data)
signature = dict_data["signature"] if "signature" in dict_data else None
if signature:
del dict_data["signature"]
url_encoded_data = urlencode(dict_data)
data = f"{url_encoded_data}&signature={signature}"

async with getattr(self.session, method)(
yarl.URL(uri, encoded=True),
proxy=self.https_proxy,
headers=headers,
data=data,
**kwargs,
) as response:
self.response = response
Expand Down
5 changes: 5 additions & 0 deletions binance/base_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ def _rsa_signature(self, query_string: str):
def encode_uri_component(uri, safe="~()*!.'"):
return _urlencode.quote(uri, safe=safe)

@staticmethod
def convert_to_dict(list_tuples):
dictionary = dict((key, value) for key, value in list_tuples)
return dictionary

def _ed25519_signature(self, query_string: str):
assert self.PRIVATE_KEY
res = b64encode(
Expand Down
14 changes: 13 additions & 1 deletion binance/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,19 @@ def _request(

kwargs = self._get_request_kwargs(method, signed, force_params, **kwargs)

self.response = getattr(self.session, method)(uri, headers=headers, **kwargs)
data = kwargs.get("data")
if data is not None:
del kwargs["data"]

if signed and self.PRIVATE_KEY and data: # handle issues with signing using eddsa/rsa and POST requests
dict_data = Client.convert_to_dict(data)
signature = dict_data["signature"] if "signature" in dict_data else None
if signature:
del dict_data["signature"]
url_encoded_data = urlencode(dict_data)
data = f"{url_encoded_data}&signature={signature}"

self.response = getattr(self.session, method)(uri, headers=headers, data=data, **kwargs)
return self._handle_response(self.response)

@staticmethod
Expand Down
Loading