Fix infinite loop, specificity bug#257
Merged
sammycage merged 1 commit intosammycage:masterfrom Jan 8, 2026
Merged
Conversation
Owner
|
Thank you <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a infinite loop when processing some SVG files. Fixing that loop also exposed an additional bug that caused the test svg fail to render incorrectly. The fix adds pseudo-class selectors to the specificity calculation with weight 0x100 (same as class and attribute selectors per CSS spec). Now rect:first-of-type has specificity 0x101 (element + pseudo-class) while plain rect has 0x1, so the first rectangle will correctly be red.
Test SVG