do not export symbols in static unix builds#28
Merged
sammycage merged 1 commit intosammycage:masterfrom May 25, 2025
sezero:static-hidden
Merged
do not export symbols in static unix builds#28sammycage merged 1 commit intosammycage:masterfrom sezero:static-hidden
sammycage merged 1 commit intosammycage:masterfrom
sezero:static-hidden
Conversation
sezero
added a commit
to libsdl-org/plutosvg
that referenced
this pull request
May 20, 2025
(Patch submitted to mainstream at sammycage#28)
Contributor
Author
|
PING ? |
Owner
|
Hey, thanks for the PR! The fix looks solid to me. Just wondering—what was the issue exactly? Did you get any errors or warnings when building on Unix? |
Contributor
Author
You're welcome
When linked statically into SDL_ttf, the resulting libSDL3_ttf.so had pluto{s}vg symbols exported, which isn't wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.