Add an option to use an external version of FreeType, and make install target optional#34
Open
Count-MHM wants to merge 1 commit intosammycage:masterfrom
Open
Add an option to use an external version of FreeType, and make install target optional#34Count-MHM wants to merge 1 commit intosammycage:masterfrom
Count-MHM wants to merge 1 commit intosammycage:masterfrom
Conversation
Owner
|
Interesting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using FreeType as a submodule (or including FreeType’s source code by any other means), the current CMake configuration generates an error if FreeType is not installed, even if it’s already available as a target.
This PR adds an option, PLUTOSVG_EXTERNAL_FREETYPE, which links against the locally available FreeType instead of locating it via find_package.
It also introduces an option, PLUTOSVG_INSTALL, which defaults to ON if this is the top-level CMake project and OFF otherwise. Users can override it to disable the install target and make it optional.
Note: The install target makes using FreeType directly impossible.