Improve Download JSON Parsing Performance#74
Closed
alexanderkiel wants to merge 1 commit intomainfrom
Closed
Conversation
The standard encoding/json lib is quite slow because it uses reflection. There are some third party drop-in replacements like https://github.com/json-iterator/go or https://github.com/goccy/go-json. I decided to go with https://github.com/goccy/go-json because it's actively maintained. The speedup is about 2x. The download of 1 million cached patient resources finishes in 11 seconds compared to 25 seconds before. Other downloads of real FHIR searches or uncached resources is not faster, but the CPU usage of blazectl is about half as much.
Member
Author
|
We shouldn't use this. See: https://github.com/go-json-experiment/jsonbench |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard encoding/json lib is quite slow because it uses reflection. There are some third party drop-in replacements like https://github.com/json-iterator/go or https://github.com/goccy/go-json. I decided to go with https://github.com/goccy/go-json because it's actively maintained.
The speedup is about 2x. The download of 1 million cached patient resources finishes in 11 seconds compared to 25 seconds before. Other downloads of real FHIR searches or uncached resources is not faster, but the CPU usage of blazectl is about half as much.