Skip to content

Conversation

@samsrabin
Copy link
Owner

@samsrabin samsrabin commented Oct 8, 2025

Just making this PR to be able to easily show the CLM-side changes needed to work with FATES edge forest and flammability stuff.

samsrabin and others added 30 commits July 17, 2024 14:26
- Adds history variables to that testmod
- Adds a version with monthly history frequency (FatesColdAllVarsMonthly)
- Adds a 49-month FatesColdAllVarsMonthly test to fates suite.
"Refactor calculation of FATES_LBLAYER_COND_AP, FATES_STOMATAL_COND_AP."
Branch refactor-history-2: Refactor: Age-class vars to update_history_hifrq2_ageclass()
Branch refactor-history-2: Update class indices in cohort loop.
Branch refactor-history-2: Add a TODO.
Branch refactor-history-2-dev: Add mortality component outputs.
Branch refactor-history-2-dev: TESTING ONLY: Add non-per-ageclass versions of history vars.
    * FATES_CANOPYAREA
    * FATES_NCL
    * FATES_PATCHAREA
    * FATES_SCORCH_HEIGHT_PF
    * FATES_SECONDAREA_ANTHRODIST
    * FATES_SECONDAREA_DIST
    * FATES_ZSTAR
Branch refactor-history-2-dev: Fix weighting of FATES_NCL, FATES_SCORCH_HEIGHT_PF.
Branch refactor-history-2-dev: Move reset_history_dyn2() call to after both update_history_dyn2*().
Branch refactor-history-2-dev: Revert "Add mortality component outputs."
refactor-history-2-dev: Add SumMortForHistory() function to fates_cohort_type.
Branch refactor-history-2-dev:Fix FATES_MORTALITY_D_*_SZAP outputs.
Branch refactor-history-2-dev: Per-ageclass termination mortality now * days_per_year.
Branch refactor-history-2-dev: Remove mortality component diagnostic outputs.
Branch isforest-20241016: Add IS_FOREST* and other useful outputs.
Branch isforest-20241016: Combine isforest functions into one.
Branch edge-area-202410: Fix and rename edge forest bin variables.
Branch edge-area-202410: Revert "Delete unneeded use "FatesIOVariableKindMod" in FatesHistoryInterfaceMod."
Branch edge-area-202410: Revert "Revert "My diagnostic outputs now use group_dyna_*.""
Branch edge-area-202410: Move FATES_IS_FOREST_AP calc to update_history_dyn2_ageclass().
Branch edge-area-202410: Revert "Revert "Delete unneeded use "FatesIOVariableKindMod" in FatesHistoryInterfaceMod.""
Branch edge-area-202410: Add param file to work with previous.
(Also updates FATES to point to my version that's up-to-date with sci.1.84.0_api.40.0.0.

Bring in various cleanup efforts found in previous testing after the chill changes came in

Various updates for testing and other problems identified in the
cesm3_0_beta04 tag. So fixes and cleanup for usability.
Including the following:

- Fix SHR_ASSERT so single-point matrix test passes
- ne3np4 to namelist_defaults_ctsm.xml and Makefile for PTS mode and add ability
- Fixes warm starts in PTS_MODE so that SCAM can use restart files
- f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile
- Changes in the FORTRAN code to properly abort when fire-emission is asked for
  it can't be provided. Added unit testing for this.

# Conflicts:
#	.gitmodules
#	bld/namelist_files/namelist_defaults_ctsm.xml
#	ccs_config
#	cime_config/testdefs/testmods_dirs/clm/FatesColdAllVars/user_nl_clm
#	src/fates
Fix FatesHistoryInterfaceMod.
samsrabin added 29 commits July 8, 2025 12:20
* Bugfix: Start all area_in_edgeforest_bins at 0.
* init_patches(): Don't pass younger patch in call of Patch%Create().
* Add some extra error messaging at bad sum_bin_weight_of_all_patches.
* Add extra condition for edge bin weight discrepancy check.
* Bugfix: Restore currentSite%rxfire_area_fuel update.
ckoven added a commit to ckoven/E3SM that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant