Fix internal errors in type checker #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.1 to 6.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4.6.1...v6.0.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.2.2...v6.0.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.1 to 8.0.0. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7.0.1...v8.0.0) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 15 files in this pull request and found no issues.
…od types When a non-function type is used as a method type, function->method now returns a proper type error with a dummy function type instead of raising an internal error. Co-Authored-By: Claude Opus 4.5 <[email protected]> Closes racket#929
Previously, dcon-meet would hit an internal error when encountering a dcon-exact paired with dcon-dotted. Added explicit cases to return Co-Authored-By: Claude Opus 4.5 <[email protected]> Closes racket#509
When looking up a struct property type, consolidated error handling into a single match expression that properly handles missing types and non- struct-property types instead of causing internal errors. Co-Authored-By: Claude Opus 4.5 <[email protected]> Closes racket#1352
Added null checks in compute-defs to handle cases where identifier-binding returns #f or when the definition lookup fails. This fixes internal errors with recursive MListof types, recursive case-> types, and recursive contract generation. Co-Authored-By: Claude Opus 4.5 <[email protected]> Closes racket#1158 Closes racket#848 Closes racket#858
Added defensive patterns to handle void values that can propagate through the type checker when earlier errors occur. Updated add-unconditional-prop, add-unconditional-prop-all-args, and type-table->tooltips to gracefully handle invalid inputs. Co-Authored-By: Claude Opus 4.5 <[email protected]> Closes racket#1157
samth
force-pushed
the
claude/fix-internal-errors-mwPZ4
branch
from
2d49182 to
879e625
Compare
There was a problem hiding this comment.
Resyntax analyzed 15 files in this pull request and found no issues.
Row type variables (declared with #:row) may only appear in (Class #:row-var ...) positions, not directly as types. Previously, code like (All (r #:row) (-> r r)) was accepted but caused internal errors during type checking. This fix adds validation in parse-type.rkt to reject row type variables in invalid positions at parse time, providing a clear error message. Also keeps defensive checks in check-below.rkt for Row types and void values from error propagation. Closes racket#1146
samth
force-pushed
the
claude/fix-internal-errors-mwPZ4
branch
from
879e625 to
9cf6154
Compare
The Class: match expander from types/classes.rkt returns 6 fields: row-ext, inits, fields, methods, augments, init-rest. The previous code incorrectly bound the second field to 'row' expecting it to be a Row type, but it was actually 'inits' (a list of tuples that can be '() when empty). This caused a contract violation when trying to call Rep-for-each on '()'. Fixed by using correct field names and iterating through the row member lists to check their types for invalid row variable usage.
There was a problem hiding this comment.
Resyntax analyzed 16 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
require/typedracket/typed-racket#1352: Add validation in has-struct-property->scprovideand recursiveMListof. racket/typed-racket#1158, Error when providing values that use recursivecase->types racket/typed-racket#848, Invalid recursive contract generated racket/typed-racket#858: Add null checks in compute-defs(All (r #:row) body)racket/typed-racket#1146: Handle Row types and void in check-belowEach commit includes a test for the fix.
Test plan
racket -l typed-racket-test -- --just <test>🤖 Generated with Claude Code