Work around Microsoft's UCRT-x64 pathname rewriting. #2412
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MINGW x64 works fine, but UCRT-x64 fails one of the setGT tests. Specifically, `-n c:././.` gets silently rewritten before main() so the argv element contains `-n c;.\.\.` instead. This is a pain, and arguably we should provide a less problematic CLI alternative for this as c: was always going to trip up Windows boxes. However for now we can work around it by not having it as a separate argument and letting getopt do the tokenisation of argv into option and optarg for us by removing the space. This doesn't fix the bug obviously, but it makes it pass tests if using the UCRT environment.
Member
|
Wow, this is ugly. If the argument were quoted or escaped somehow, something like |
Contributor
Author
|
Sadly not, no. It's just a particularly dumb thing in the Microsoft runtime equivalent of crt0: the bit that happens before My fix for now was just to make the test pass so I don't trip over it again in the future, but long term we need to figure out how best to address such brokenness. |
Member
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINGW x64 works fine, but UCRT-x64 fails one of the setGT tests. Specifically,
-n c:././.gets silently rewritten before main() so the argv element contains-n c;.\.\.instead. This is a pain, and arguably we should provide a less problematic CLI alternative for this as c: was always going to trip up Windows boxes.However for now we can work around it by not having it as a separate argument and letting getopt do the tokenisation of argv into option and optarg for us by removing the space.
This doesn't fix the bug obviously, but it makes it pass tests if using the UCRT environment.