Use the highest VCF version when merging headers #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd3
added a commit
to samtools/bcftools
that referenced
this pull request
May 8, 2025
Requires the htslib update samtools/htslib#1912 Resolves #2395
jkbonfield
reviewed
May 15, 2025
vcf.c
Outdated
Comment on lines
4709
to
4710
| res = bcf_hdr_set_version(dst,src->hrec[i]->value); | ||
| need_sync += res; |
Contributor
There was a problem hiding this comment.
bcf_hdr_set_version returns 0 on success and <0 on error (eg strdup allocation failure). So it's inappropriate to do need_sync += res as at best it'll do nothing at all, or on error it may even remove the need to syncronise.
We should change that to need_sync = 1, and add an error check obviously.
jkbonfield
force-pushed
the
bt-2395-hdr-version
branch
from
d8bca8a to
8c66cb7
Compare
jkbonfield
pushed a commit
to samtools/bcftools
that referenced
this pull request
May 19, 2025
Requires the htslib update samtools/htslib#1912 Resolves #2395
jkbonfield
pushed a commit
to samtools/bcftools
that referenced
this pull request
May 19, 2025
Requires the htslib update samtools/htslib#1912 Resolves #2395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See samtools/bcftools#2395 and samtools/bcftools#2404