Minor one-line rewrite to avoid undefined behaviour#1962
Merged
vasudeva8 merged 1 commit intosamtools:developfrom Oct 10, 2025
Merged
Minor one-line rewrite to avoid undefined behaviour#1962vasudeva8 merged 1 commit intosamtools:developfrom
vasudeva8 merged 1 commit intosamtools:developfrom
Conversation
Also use `strlen(HTS_IDX_DELIM)` for clarity -- it will be optimised to the same constant anyway.
Contributor
|
Thank you John, it is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even adding zero to a null pointer is not kosher, and produces diagnostics at runtime with
‑fsanitize=undefined:Also use
strlen(HTS_IDX_DELIM)for clarity — it will be optimised to the same constant as thesizeofversion anyway, and is already used elsewhere.