Fix IsNow/IsDatetime unix_number comparison with timezone#127
Open
bysiber wants to merge 1 commit intosamuelcolvin:mainfrom
Open
Fix IsNow/IsDatetime unix_number comparison with timezone#127bysiber wants to merge 1 commit intosamuelcolvin:mainfrom
bysiber wants to merge 1 commit intosamuelcolvin:mainfrom
Conversation
When using unix_number=True with a timezone (e.g. IsNow(unix_number=True, tz="UTC")), datetime.fromtimestamp() was called without a timezone, producing a naive datetime. This caused the comparison to fail because the approx datetime had a timezone but the converted timestamp did not. Pass the approx datetime's timezone to fromtimestamp() so both datetimes have matching timezone info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
IsNow(unix_number=True, tz="UTC")was failing becausedatetime.fromtimestamp()was called without a timezone, creating a naive datetime. When theapproxdatetime has timezone info (from thetzparameter),approx_equals()then sees a timezone mismatch and rejects the comparison.The fix passes the
approxdatetime's timezone tofromtimestamp()so the converted timestamp gets the same timezone, making the comparison work correctly.Added test assertions for
IsNow(unix_number=True, tz='UTC')andIsNow(unix_number=True, tz=timezone.utc).