-
-
Notifications
You must be signed in to change notification settings - Fork 127
feat: browser action list positioning #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: browser action list positioning #115
Conversation
|
Thanks for looking into this! I pulled down the code and I feel like the alignment options are opposite of what they should be. CSS anchor positioning solves a similar problem, and that uses the alignment position of the anchor's edge rather than the popover edge.
|
|
More than happy to amend the PR with any rec's |
Thanks, I think just inverting the alignment options would be good. |
|
I've given it the ol' switchero and updated the README.md - I've also left in the attribute in the |
|
lgtm, thank you! I made some minor changes to the docs btw. |
|
Sweet as, next week I should be able to submit a couple more PRs to help along with flagged issues, TODOs and some small features I've implemented in a local version. Thank you so much everything so far as well as this was killer find when I started toying around with electron last week 🔥 |
Great! I'll try to get around to any PRs within a few days of them being opened. Also, feel free to get in touch if there's a particular feature you'd like to discuss prior to implementing. |


added: Support for defining the position of the
<browser-action-list />web component.I've kept this simple as to allow a developer to define corner alignment rather than arbitrary positioning (which saw mentioned in #46).
Heres a demo of
top right(the default) and alsobottom right(even though I left the icons in the top left, but you should get the idea of how this is working.Screen.Recording.2025-02-28.at.20.12.23.mp4
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.