Skip to content

Conversation

@haydncomley
Copy link
Contributor

@haydncomley haydncomley commented Feb 28, 2025

added: Support for defining the position of the <browser-action-list /> web component.

I've kept this simple as to allow a developer to define corner alignment rather than arbitrary positioning (which saw mentioned in #46).

Heres a demo of top right (the default) and also bottom right (even though I left the icons in the top left, but you should get the idea of how this is working.

Screen.Recording.2025-02-28.at.20.12.23.mp4

✅ By sending this pull request, I agree to the Contributor License Agreement of this project.

@samuelmaddock
Copy link
Owner

Thanks for looking into this!

I pulled down the code and I feel like the alignment options are opposite of what they should be. CSS anchor positioning solves a similar problem, and that uses the alignment position of the anchor's edge rather than the popover edge.

Screenshot 2025-03-01 at 11 49 14 AM Screenshot 2025-03-01 at 11 49 50 AM

@haydncomley
Copy link
Contributor Author

More than happy to amend the PR with any rec's

@samuelmaddock
Copy link
Owner

More than happy to amend the PR with any rec's

Thanks, I think just inverting the alignment options would be good.

@haydncomley
Copy link
Contributor Author

I've given it the ol' switchero and updated the README.md - I've also left in the attribute in the webui.html just as I think it serves as a quick pointer if someones checking out the usage

@samuelmaddock
Copy link
Owner

lgtm, thank you! I made some minor changes to the docs btw.

@samuelmaddock samuelmaddock merged commit 255a923 into samuelmaddock:master Mar 1, 2025
1 check passed
@haydncomley
Copy link
Contributor Author

Sweet as, next week I should be able to submit a couple more PRs to help along with flagged issues, TODOs and some small features I've implemented in a local version. Thank you so much everything so far as well as this was killer find when I started toying around with electron last week 🔥

@samuelmaddock
Copy link
Owner

Sweet as, next week I should be able to submit a couple more PRs to help along with flagged issues, TODOs and some small features I've implemented in a local version. Thank you so much everything so far as well as this was killer find when I started toying around with electron last week 🔥

Great! I'll try to get around to any PRs within a few days of them being opened. Also, feel free to get in touch if there's a particular feature you'd like to discuss prior to implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants