fix: multiple sessions with chrome webstore not working #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are a few downstream effects of the bug that I mentioned here: #117 that might be worth looking into as well. |
Contributor
Author
Oh, that’s why my extensions were slightly glitching out 😂 I’ll see if i can make a fix for those too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Error: Attempted to register a second handler for 'xxx'
This is because it is trying to register the IPC twice as I initialised it on two different sessions.
Solution
A
handledIpcChannelsmap to only handle each IPC channel once, and route the requests to the right ChromeWebStore instance.closes #117
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.