Improved Web Store Management#138
Conversation
|
Would it also be possible to add an |
I think this already exists from this commit. |
|
yes, sweet! |
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
samuelmaddock
left a comment
samuelmaddock
left a comment
There was a problem hiding this comment.
For future reference, I'd recommend breaking up each API addition into separate PRs. That way feedback for one doesn't need to block the others.
| queueMicrotask(() => { | ||
| webStoreState.afterUninstall?.({ id }) | ||
| }) |
There was a problem hiding this comment.
Is the queueMicrotask needed?
| queueMicrotask(() => { | |
| webStoreState.afterUninstall?.({ id }) | |
| }) | |
| webStoreState.afterUninstall?.({ id }) |
| session: webStoreState.session, | ||
| extensionsPath: webStoreState.extensionsPath, | ||
| } | ||
| await webStoreState.customSetExtensionEnabled(id, details, enabled) |
There was a problem hiding this comment.
Rename to setExtensionEnabled and add documentation referencing chrome.management.setEnabled
| extensionId: ExtensionId, | ||
| manifest?: chrome.runtime.Manifest, | ||
| ) { | ||
| if (state.overrideExtensionInstallStatus) { |
There was a problem hiding this comment.
Rename to getExtensionInstallStatus
3 participants
Summary
This PR makes it possible for users to create a custom extensions management system (Install, Uninstall, Enable & Disable)
Changes
afterInstalloption toinstallChromeWebStore(), which allows the users to specifically track extensions installed via the webstore.afterUninstalloption toinstallChromeWebStore(), which allows the users to specifically track extensions uninstalled via the webstoreoverrideExtensionInstallStatusoption toinstallChromeWebStore(), which allows the users to override the extension state passed to the webstore. (eg: Disabled, Blacklisted, Corrupted, etc)Why?
These changes allowed me to implement a custom extension management system here, while maintaining the state with
electron-chrome-web-store.closes #116
✅ By sending this pull request, I agree to the Contributor License Agreement of this project.