Deprecate ResourceListWriter class

[maxkadel]

Fixes

refs #7318; refs samvera/maintenance#175

Summary

Deprecate ResourceListWriter class, also proposes new pattern for deprecations:

• For entire classes: Manual warn in initialize and deprecate_methods for other methods
• For individual methods: Just deprecate_methods
• For marking technical debt: Hyrax.deprecator(4).warn("Should have been removed in 4.0...")

Type of change (for release notes)

• notes-deprecation Deprecations

Changes proposed in this pull request:

• Create a custom deprecator class to handle tech debt of deprecated but still-there methods
• Deprecate ResourceListWriter class

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    13 files  ±0      13 suites  ±0   2h 46m 17s ⏱️ +30s
 6 977 tests  - 1   6 671 ✅  - 1  306 💤 ±0  0 ❌ ±0 
18 578 runs  +7  18 077 ✅ +7  501 💤 ±0  0 ❌ ±0 

Results for commit 1d3a1dd. ± Comparison against base commit ef22231.

This pull request removes 367 and adds 366 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f01d098a7a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc3d26dd498>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd79b5a6a48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f01d09694d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc3d282cd08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd79b46be08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 69bc21e6-a539-4853-8fc6-39b4e5febe8f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 30ed5322-1782-4106-a3c5-a6f5f4f5e100
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 91bd9d15-44b9-4a0f-916d-1c1a6a49ec0d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 13d90fba-d136-4644-a859-ae765c44e86f
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f81c234d988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9acfb67080>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fba44477448>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f81bebd0140>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9acfb81548>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fba4446af18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e18308fe-7727-4031-94fd-005ee8417314
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 958643ba-1911-4e47-bf30-908fc9435851
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c4b82867-de74-481b-a2fa-ea1de6d91565
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6cfaac59-50f9-45e7-8d58-ffc157328f0f
…

♻️ This comment has been updated with latest results.