-
Notifications
You must be signed in to change notification settings - Fork 132
Add FindByPropertyValue custom queries and add bulkrax to test applications #7320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Includes four permutations of query styles, including `find_by_property_value` as a replacement for the one bulkrax currently provides.
Various non-valkyrie code paths are used conditionally if the `Wings` constant is defined. This is not a problem for dassie, but is used there too to stay consistent.
Test Results 13 files ± 0 8 errors 5 suites - 8 2h 1m 55s ⏱️ - 47m 33s For more details on these parsing errors and failures, see this check. Results for commit 66d749a. ± Comparison against base commit b29b5e6. This pull request removes 434 and adds 196 tests. Note that renamed tests count towards both.This pull request skips 16 tests.♻️ This comment has been updated with latest results. |
|
Just as a head's up, because I didn't see it in your code for .dassie/.koppie, but I believe it's necessary to specify a |
Fixes
Fixes #7119
Summary
Support for bulkrax in Valkyrie w/Fedora applications.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Detailed Description
In order to better support the widely used bulkrax tool, it has been installed in the test applications (and therefore also in the nurax servers).
It was discovered the
find_by_property_valuecustom query provided by bulkrax was written assuming postgres would be the metadata adapter in use. This has been replaced in this PR by a set of custom queries instead utilizing solr.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers