Minor Fix: Changed 'NamedShape' to 'DShapedArray' in layers.py for newer JAX version compatibility#210
Open
obbwins wants to merge 1 commit intosanchit-gandhi:mainfrom
Open
Conversation
…edArray for compatibility with newer JAX versions
|
This fix helped me – thanks. @sanchit-gandhi, could you consider merging this? (And also #177) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor incompatibility with newer JAX versions by updating the type annotation from jax.core.NamedShape to jax.core.DShapedArray in the compute_fans function.
This is a minimal change to address the immediate compatibility issue. I'm not super experienced with JAX so please let me know if an alternative is better :)
Tested with JAX version: 0.6.0