Open
Conversation
Use es2020 environment and EcmaScript 11 for BigInt type and literals. Fix `comma-dangle` errors.
Member
|
Thank you very much for this contribution, @eush77. I'm sorry for taking so long to review it! I would like to reduce the scope of the changes. If we remove What do you think? I realize that months have passed and you've no doubt moved on to other things. If you'd like to update the pull request yourself, I promise not to leave you hanging again. If you'd prefer for me to make the changes, just say so. Thanks again for making Sanctuary better. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines
BigInttype.Since it requires ES2020, update ESLint configuration for testing. This triggered
comma-danglein a bunch of places for me, so I fixed those, too.The actual functional change in
index.jsdoes not require ES2020.