maybe, either: remove S.maybeToEither and S.eitherToMaybe#664
Merged
davidchambers merged 1 commit intomasterfrom Aug 9, 2020
Merged
maybe, either: remove S.maybeToEither and S.eitherToMaybe#664davidchambers merged 1 commit intomasterfrom
davidchambers merged 1 commit intomasterfrom
Conversation
davidchambers
commented
Jan 16, 2020
Comment on lines
-4278
to
+4335
| return B (filter (pred)) (B (eitherToMaybe) (encase (JSON.parse))); | ||
| return B (filter (pred)) | ||
| (B (either (K (Nothing)) (Just)) | ||
| (encase (JSON.parse))); |
Member
Author
There was a problem hiding this comment.
I find the new implementation just as clear as the existing one. either (K (Nothing)) (Just) is the natural transformation from either to maybe. :)
Member
|
Things like this can probably go into a hypothetical sanctuary lens library, which would make it easier to convert back and forth and fill in cells in the "conversion matrix" via ad-hoc composition. |
ca87d78 to
cb667b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
I appreciate the concern @Avaq expressed in #644 (comment):
If others agree with this change, I would like to merge this pull request then rebase and merge #644. If you do not think these two functions should be removed, please say so. :)
/cc @futpib, @masaeedu