Change the meaning of fromEither#690
Merged
davidchambers merged 1 commit intosanctuary-js:masterfrom Aug 16, 2020
Merged
Conversation
| types: [b, $.Either (a) (b), b], | ||
| impl: fromEither | ||
| types: [$.Either (a) (a), a], | ||
| impl: either (I) (I) |
davidchambers
approved these changes
Aug 15, 2020
Member
davidchambers
left a comment
davidchambers
left a comment
There was a problem hiding this comment.
Looks great!
Please rebase your branch to allow me to merge it (we require the source branch to be up to date with master).
davidchambers
force-pushed
the
fromEither
branch
from
b7d6df8 to
57fb03d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#644 (comment)