New filter sidebar #324
Open
New filter sidebar #324
+1,296
−511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
gpalmer27
requested changes
Jan 1, 2026
Collaborator
There was a problem hiding this comment.
I'm just putting all of my thoughts here, some of it will be super nitpicky, my apologies:
- For the chips at the top, in the figma then the 'all' chip doesn't have a number next to it, do we want to remove the number in the filters sidebar and on the regular sidebar or should we keep it
- I think the padding is a bit off for the search bar and selected results for industry + location
- idk if this is intended behavior but shouldn't the results be right under the search bar instead of under the things already selected?
- The text for the 'clear all' + show results at the bottom should match the figma (darker color)
- numbers should be a bit bigger for company culture
- company culture and overtime work shouldn't have a clear, also make the text exactly match the figma for "overtime commonly expected"
- let's try to get the bottom part working ideally before the new devs come so that we don't have to start the semester with schema mismatches
gpalmer27
requested changes
Jan 28, 2026
Collaborator
gpalmer27
left a comment
gpalmer27
left a comment
There was a problem hiding this comment.
super super nitpicky but can you make the 'clear's all centered with the text to the left of them and can you make the 'clear' for on the job the same weight as all the other clears?
also for the arrows for the hourly pay, i feel like we don't want them to be able to go negative
also here, i entered smth for the hourly pay but it doesn't show up and it looks out of place since all of the other filters have something there
gpalmer27
approved these changes
Jan 30, 2026
…oxnu/cooper into new-filter-sidebar" This reverts commit ff7670b, reversing changes made to 19e4852.
* hid companies and roles with no reviews * fixed linting * fixed header * review form works i think pls * hid roles and companies with no reviews from profile page * fixed typecasting * fixed types * fixed format * removed console logs * fixed lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the filter sidebar! With most functionality and syncing with the header filters. Also refactored some of the filters for reusability. Also changed the placement of the job comparator button to more closely align with the figma.
"On the job" functionality DOES NOT WORK RN BTW need to first potentially make schema changes again
Also it doesn't align like 100% with the figma but will change later
Motivation and Context
Closes #291
How has this been tested?
played around with it lol
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: