-
Notifications
You must be signed in to change notification settings - Fork 0
Change jobtype for reviews not role #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
| key={model.name} | ||
| className={`h-full rounded-lg ${ | ||
| model.name === "In-person" | ||
| model.name === "Inperson" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no dash in between
|
Should show 'co-op/internship' in role preview + role info card |
…into change-jobtype
leeyandrea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
what it says in the title above. also fixed bug with company popup where pay amounts were appearing multiple times!
Motivation and Context
Closes #344
How has this been tested?
created several new reviews and made sure it worked for both coop and internship and that nothing broke anywhere the .jobtype was originally referenced
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: