Fastapi template windows #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Let's go with this option. This will make it so Windows developers and *nix developers can use the same lock file and everyone gets what they need. It will also cover the most likely production scenarios getting |
sanders41
requested changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
uvloopis only supported on unix systems, I added a OS check so that it's only added as a dependency if we're generating the project on a unix machine.Another option could be to make the dependency:
"uvloop; sys_platform != 'win32'"
which would then only get installed by the package manager if we're on windows. The upside here is we don't have to manage which OS we're running on for project generation, the downside being that it would be added to all project configs, including those that may only be windows-based.
I'm open to suggestions on which method is preferred, and I can make any updates.