Refactors Arcus repository for an "intermediate" 3.x.y release#60
Merged
Refactors Arcus repository for an "intermediate" 3.x.y release#60
Conversation
The is a known broken test case for Arcus.Tests.IPAddressCompatibilityTests.IPAddressTryParseSuccessTest for the input `abcd::%`
#59 - Subnet.TryIPv4FromPartial(string , out Subnet) throws FormatException if the string input contains a malformed 0-prefixed octet that is not a valid octal number.
I made a bad assumption, `Roslynator.Testing.CSharp.Xunit` is not relevant
Co-authored-by: Drew Antonich <drewanton@gmail.com>
drewantonich
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now targeting .NET Standard 2.0, .NET 8, and .NET 9. Dropping support for .NET Standard 1.3
This "modernized" version is intended to be a stutter step before any API changes for a potential version 4
Subnet.TryIPv4FromPartial(string , out Subnet)throwsFormatExceptionif thestringinput contains a malformed 0-prefixed octet that is not a valid octal number. #59This includes an indirect breaking changes as related to the parsing of IP Addresses and how they differ from the previous .NET Standard 1.3 target. See README.md for notes.