Improved error handling #96
Open
+333
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibalde
approved these changes
Oct 23, 2025
| } else { | ||
| error_code = FENIX_ERROR_UNINITIALIZED; | ||
| for(auto it = fenix.callbacks.rbegin(); it != fenix.callbacks.rend(); it++){ | ||
| (*it)(*fenix.user_world, error); |
There was a problem hiding this comment.
Clarifying question: new_world and user_world are intended to be effectively the same communicator?
There was a problem hiding this comment.
Yeah, new_world is just a duplicated user_world for using internally without interfering with the application. It should definitely be renamed for more clarity at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR 95.
I'll have another PR soon for refactoring the namespace from
Fenix::->fenix::so we're more conventional. It's a bunch of find-and-replace for the globalfenix_t fenixobject, so it would make it annoying to review this PR.