Skip to content

Flexibility for LF push#24

Open
reuterb wants to merge 4 commits intomainfrom
lf-push-options
Open

Flexibility for LF push#24
reuterb wants to merge 4 commits intomainfrom
lf-push-options

Conversation

@reuterb
Copy link
Collaborator

@reuterb reuterb commented Mar 25, 2026

No description provided.

@caleblogemann
Copy link
Collaborator

I think this is good for what we need right now.

My very preliminary thoughts were trying to plan for the online variance reduction. I was thinking about a class called ChargeWeightingOperations or something similar that would take or store ParticleContainer and LowFidelityState and would return an IntegratedCharge object. The ChargeWeightingOperations would have an input option to switch between using ParticleContainer or LowFidelityState. We could then add options for different variance reduction techniques later.

This idea could be more than what we need right now though.

@reuterb
Copy link
Collaborator Author

reuterb commented Mar 25, 2026

I think this is good for what we need right now.

My very preliminary thoughts were trying to plan for the online variance reduction. I was thinking about a class called ChargeWeightingOperations or something similar that would take or store ParticleContainer and LowFidelityState and would return an IntegratedCharge object. The ChargeWeightingOperations would have an input option to switch between using ParticleContainer or LowFidelityState. We could then add options for different variance reduction techniques later.

This idea could be more than what we need right now though.

@gyalla is prototyping a online variance reduction in a different MR that just starts on a few of this issues. I think what you are suggesting sounds more like what we'd want to do longer term to keep things well organized. Anyway, just an FYI but you all should probably chat and he can show you that work.

@reuterb reuterb requested a review from caleblogemann March 26, 2026 15:09
@reuterb
Copy link
Collaborator Author

reuterb commented Mar 26, 2026

@caleblogemann Not 100% done but I think it would be good for you to take a look if you have a minute. We need to go back and restructure some of the LF/HF handling of fields and outputs at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants