prevent writing to config regardless of cwd#74
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent tests from writing to the real project .nsite/config.json regardless of the current working directory by adding an explicit “test mode” signal and strengthening write guards in config writing code.
Changes:
- Add
DENO_TESTINGenv flag in global test setup and use it inwriteProjectFileto block default config writes during tests. - Add additional guarding in
writeProjectFileto prevent tests from writing to non-temp paths even whenconfigPathis explicitly provided. - Change deploy upload server resolution to stop merging in the user’s kind
10063Blossom server list, and update the repo’s.nsite/config.jsonserver list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
tests/test-setup-global.ts |
Sets a new env flag intended to identify the test runtime. |
src/lib/config.ts |
Updates config-writing logic to detect test mode and block writes to “real” paths. |
src/commands/deploy.ts |
Changes how upload servers are resolved (no longer merges user 10063 server list). |
.nsite/config.json |
Updates the checked-in project config server list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.