Skip to content

Enhance/tighten ontology#82

Merged
dskvr merged 2 commits intoenhance/more-stats-in-deployfrom
enhance/tighten-ontology
Mar 13, 2026
Merged

Enhance/tighten ontology#82
dskvr merged 2 commits intoenhance/more-stats-in-deployfrom
enhance/tighten-ontology

Conversation

@dskvr
Copy link

@dskvr dskvr commented Mar 13, 2026

No description provided.

@dskvr dskvr requested review from Copilot and removed request for Copilot March 13, 2026 12:43
@dskvr dskvr changed the base branch from main to enhance/more-stats-in-deploy March 13, 2026 12:43
@dskvr dskvr requested a review from Copilot March 13, 2026 12:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens and expands nsyte’s deployment/delete UX by adding per-server progress tracking (with interactive toggling), introducing delete/undeploy command flows, and shifting deploy behavior from “purge” toward “sync/backfill” semantics.

Changes:

  • Add per-server upload progress accounting and a multi-line terminal renderer (toggle with s) to visualize server-level progress.
  • Replace/alias the legacy purge command with delete, and add a new undeploy command for “nuclear” teardown (delete all blobs + manifest).
  • Update deploy CLI/options/docs to support --sync (backfill missing blobs) and refine --force semantics.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/unit/ui_progress_test.ts Updates unit expectations for new line-clearing behavior and progress output.
src/ui/progress.ts Adds multi-line progress rendering + keypress toggling + per-server bars.
src/ui/browse/renderer.ts Switches server indicators to getServerSymbol(index) (deprecates SERVER_SYMBOL).
src/lib/upload.ts Refactors upload progress to “files × servers”, adds per-server progress, and moves retries to per-server logic.
src/lib/files.ts Improves implicit dotfile ignore detection when deploying from a dot-directory.
src/commands/undeploy.ts Adds a full undeploy command: delete blobs on servers + publish manifest delete event.
src/commands/list.ts Adds server symbol cycling + expanded server color palette; updates server indicators.
src/commands/deploy.ts Replaces purge with sync; adds richer upload output + server summary formatting + server timing display.
src/commands/delete.ts Renames purge command to delete, keeps purge as deprecated alias, updates copy.
src/cli.ts Registers delete and new undeploy commands.
mkdocs.yml Updates docs navigation to include deploy/delete/undeploy.
docs/usage/index.md Updates usage docs to reflect --sync and delete terminology.
docs/usage/commands/undeploy.md Adds full documentation for the new undeploy command.
docs/usage/commands/deploy.md Updates deploy docs for --sync and revised --force.
docs/usage/commands/delete.md Renames purge docs to delete; notes purge alias deprecation.
docs/usage/commands/browse.md Updates “See also” references to delete.
docs/usage/commands.md Updates command list and legacy notes.
docs/guides/deployment.md Updates guide to discuss sync instead of purge.
README.md Updates top-level command list and deploy examples/options.
.nsite/config.json Expands default configured servers in the repo config.
Comments suppressed due to low confidence (2)

src/lib/upload.ts:636

  • In the retry loop, a successful outcome that is actually alreadyExists is currently emitted as completed, which will undercount skipped and misreport per-server/global progress. Emit skipped when outcome.alreadyExists is true (same as the initial attempt) and only emit completed for newly uploaded blobs.
            const outcome = await uploadToServer(server, file, authHeader, force);
            const success = outcome.success || outcome.alreadyExists;
            serverResults[server] = {
              success,
              alreadyExists: outcome.alreadyExists,
              error: success ? undefined : outcome.error,
              retries: attempt,
            };
            if (success) {
              onServerEvent?.(server, "completed");
              return;
            }

src/commands/deploy.ts:428

  • formatServerSummary() calls formatTable() once per row, which prevents column widths from being computed across all rows and will lead to misaligned columns when server names/ratios vary. Collect rows for all servers first and call formatTable(rows) once at the end (similar to formatServerResults() in ui/formatters.ts).

    const row = formatTable([[status, server, ratio + detailStr]]);
    lines.push(row);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

dskvr and others added 2 commits March 14, 2026 00:07
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dskvr dskvr force-pushed the enhance/tighten-ontology branch from 89f0648 to a9ba750 Compare March 13, 2026 23:08
@dskvr dskvr merged commit cef836c into enhance/more-stats-in-deploy Mar 13, 2026
3 checks passed
dskvr added a commit that referenced this pull request Mar 13, 2026
* indicate which blobs successfully uploaded to which servers, filetypes of each blob and sizes of each blob

* harden deployment mechanisms, add redundancy and more safeguards

* split progress bars per server

* standardize progress bar colors

* add more progress stats

* resolve code reviews

* Enhance/tighten ontology (#82)

* purge -> delte, add undeploy command, update docs

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: sandwich <dskvr@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: sandwich <dskvr@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants