Enhance/tighten ontology#82
Merged
dskvr merged 2 commits intoenhance/more-stats-in-deployfrom Mar 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens and expands nsyte’s deployment/delete UX by adding per-server progress tracking (with interactive toggling), introducing delete/undeploy command flows, and shifting deploy behavior from “purge” toward “sync/backfill” semantics.
Changes:
- Add per-server upload progress accounting and a multi-line terminal renderer (toggle with
s) to visualize server-level progress. - Replace/alias the legacy
purgecommand withdelete, and add a newundeploycommand for “nuclear” teardown (delete all blobs + manifest). - Update deploy CLI/options/docs to support
--sync(backfill missing blobs) and refine--forcesemantics.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/ui_progress_test.ts | Updates unit expectations for new line-clearing behavior and progress output. |
| src/ui/progress.ts | Adds multi-line progress rendering + keypress toggling + per-server bars. |
| src/ui/browse/renderer.ts | Switches server indicators to getServerSymbol(index) (deprecates SERVER_SYMBOL). |
| src/lib/upload.ts | Refactors upload progress to “files × servers”, adds per-server progress, and moves retries to per-server logic. |
| src/lib/files.ts | Improves implicit dotfile ignore detection when deploying from a dot-directory. |
| src/commands/undeploy.ts | Adds a full undeploy command: delete blobs on servers + publish manifest delete event. |
| src/commands/list.ts | Adds server symbol cycling + expanded server color palette; updates server indicators. |
| src/commands/deploy.ts | Replaces purge with sync; adds richer upload output + server summary formatting + server timing display. |
| src/commands/delete.ts | Renames purge command to delete, keeps purge as deprecated alias, updates copy. |
| src/cli.ts | Registers delete and new undeploy commands. |
| mkdocs.yml | Updates docs navigation to include deploy/delete/undeploy. |
| docs/usage/index.md | Updates usage docs to reflect --sync and delete terminology. |
| docs/usage/commands/undeploy.md | Adds full documentation for the new undeploy command. |
| docs/usage/commands/deploy.md | Updates deploy docs for --sync and revised --force. |
| docs/usage/commands/delete.md | Renames purge docs to delete; notes purge alias deprecation. |
| docs/usage/commands/browse.md | Updates “See also” references to delete. |
| docs/usage/commands.md | Updates command list and legacy notes. |
| docs/guides/deployment.md | Updates guide to discuss sync instead of purge. |
| README.md | Updates top-level command list and deploy examples/options. |
| .nsite/config.json | Expands default configured servers in the repo config. |
Comments suppressed due to low confidence (2)
src/lib/upload.ts:636
- In the retry loop, a successful outcome that is actually
alreadyExistsis currently emitted ascompleted, which will undercountskippedand misreport per-server/global progress. Emitskippedwhenoutcome.alreadyExistsis true (same as the initial attempt) and only emitcompletedfor newly uploaded blobs.
const outcome = await uploadToServer(server, file, authHeader, force);
const success = outcome.success || outcome.alreadyExists;
serverResults[server] = {
success,
alreadyExists: outcome.alreadyExists,
error: success ? undefined : outcome.error,
retries: attempt,
};
if (success) {
onServerEvent?.(server, "completed");
return;
}
src/commands/deploy.ts:428
formatServerSummary()callsformatTable()once per row, which prevents column widths from being computed across all rows and will lead to misaligned columns when server names/ratios vary. Collect rows for all servers first and callformatTable(rows)once at the end (similar toformatServerResults()in ui/formatters.ts).
const row = formatTable([[status, server, ratio + detailStr]]);
lines.push(row);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
89f0648 to
a9ba750
Compare
dskvr
added a commit
that referenced
this pull request
Mar 13, 2026
* indicate which blobs successfully uploaded to which servers, filetypes of each blob and sizes of each blob * harden deployment mechanisms, add redundancy and more safeguards * split progress bars per server * standardize progress bar colors * add more progress stats * resolve code reviews * Enhance/tighten ontology (#82) * purge -> delte, add undeploy command, update docs * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: sandwich <dskvr@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: sandwich <dskvr@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.