Fixed when FishBun.isStartInAllView(true) returned empty array to onActivityResult#256
Open
LGFox wants to merge 2 commits intosangcomz:developfrom
Open
Fixed when FishBun.isStartInAllView(true) returned empty array to onActivityResult#256LGFox wants to merge 2 commits intosangcomz:developfrom
LGFox wants to merge 2 commits intosangcomz:developfrom
Conversation
Owner
|
Thanks for the PR. I'll check. :) |
|
Hi @sangcomz, could you please check this PR and merge it? It's relatively small and straight forward. I was actually going to submit basically the same changes but now I saw that LGFox already did the work. |
|
Please merge this pj and release a new version to fix this problem, I really need this libs for upgrade sdk 33. Thank you! |
|
Please merge this PR and release a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
WithActivityActivity.kt:147add.isStartInAllView(true)Activity in StartActivityForResult(LIGHT)CHOOSEExpected result: a photo being selected
Actual result: app crashes because
pathatWithActivityActivity.kt:60isnullWhat changed:
finish()instead ofpickerView.finishActivity()which correctly supportsisStartInAllView(true)pickerRepository.checkForFinish()everywhere.setIsUseAllDoneButton(true)in demo project