Skip to content

Fixed when FishBun.isStartInAllView(true) returned empty array to onActivityResult#256

Open
LGFox wants to merge 2 commits intosangcomz:developfrom
LGFox:isStartInAllView_fix
Open

Fixed when FishBun.isStartInAllView(true) returned empty array to onActivityResult#256
LGFox wants to merge 2 commits intosangcomz:developfrom
LGFox:isStartInAllView_fix

Conversation

@LGFox
Copy link

@LGFox LGFox commented Dec 9, 2022

Steps to reproduce:

  1. In WithActivityActivity.kt:147 add .isStartInAllView(true)
  2. Run demo project and select Activity in StartActivityForResult(LIGHT)
  3. Select a photo and press CHOOSE

Expected result: a photo being selected
Actual result: app crashes because path at WithActivityActivity.kt:60 is null

What changed:

  1. Call finish() instead of pickerView.finishActivity() which correctly supports isStartInAllView(true)
  2. Refactored: used pickerRepository.checkForFinish() everywhere
  3. Removed extra .setIsUseAllDoneButton(true) in demo project

@sangcomz
Copy link
Owner

Thanks for the PR. I'll check. :)

@adnandautovic
Copy link

Hi @sangcomz, could you please check this PR and merge it? It's relatively small and straight forward. I was actually going to submit basically the same changes but now I saw that LGFox already did the work.
Thank you for this library and your work on it.

@tungcyfeer
Copy link

Please merge this pj and release a new version to fix this problem, I really need this libs for upgrade sdk 33. Thank you!

@cansener
Copy link

Please merge this PR and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants