Y26 031 labware location report by retention instructions

[wendyyang]

Closes #

Changes proposed in this pull request

add retention instruction column in location report table
add filter by retention instruction on the return record

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.25%. Comparing base (a71005e) to head (7e4e26f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5637      +/-   ##
===========================================
+ Coverage    87.22%   87.25%   +0.02%     
===========================================
  Files         1461     1461              
  Lines        33022    33032      +10     
  Branches      3475     3476       +1     
===========================================
+ Hits         28805    28822      +17     
+ Misses        4196     4189       -7     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Adds retention-instruction support to Location Reports so users can filter returned labware by retention instruction, while persisting the selected instructions on the report record.

Changes:

• Add retention_instructions (serialized array) to LocationReport and persist it via a new DB column.
• Extend the selection form + controller strong params to allow multi-select retention instructions.
• Filter selected labware by retention instruction and add an RSpec scenario for it.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
spec/models/location_report_spec.rb	Adds coverage for filtering by retention instruction.
db/schema.rb	Updates schema with the new location_reports.retention_instructions column.
db/migrate/20260325134057_add_retention_instructions_to_lcation_reports.rb	Introduces the migration adding the new column.
app/views/location_reports/_location_labware_selection_form.html.erb	Adds a multi-select retention instruction filter UI.
app/models/location_report/location_report_form.rb	Passes retention_instructions from the form into the model.
app/models/location_report.rb	Serializes retention_instructions and filters labware results accordingly.
app/controllers/location_reports_controller.rb	Permits retention_instructions as an array param.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

validate_result_size currently adds an error and returns [], but does not explicitly halt callers (and returns nil on success). Consider making this method return a boolean (eg true/false) or raising/returning consistently so callers can reliably short-circuit when the limit is exceeded.

[Copilot]

location_report_params permits :barcodes and :barcodes_text twice. This duplication is redundant and can confuse future edits; remove the duplicates so each permitted key appears only once.

Suggested change

	:barcodes,
	:barcodes_text,

[Copilot]

validate_result_size(params) returns an empty array when the result set is too large, but its return value is ignored here. That means the code will still execute Labware.search_for_labware(params) even after adding the too_many_labwares_found error, defeating the safeguard and potentially loading a very large dataset. Short-circuit the method (eg return [] immediately) when the validation fails.