Open
Conversation
|
Hi @sanishkr any updates on when are u planning to merge this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates package.json peerDependencies to allow React 19 (react and react-dom).
Why: frameworks like Next.js 16 already use React 19 and previously the package's peer range only allowed up to React 18 which caused install/build failures.
Verification steps I ran: npm ci && npm test (passes), npm run build (produces dist.js), and NODE_OPTIONS=--openssl-legacy-provider npm run umd (UMD build succeeds; webpack v4 + Node may require this workaround).
Recommendations: Consider upgrading to webpack 5 or adding a CI env var to set NODE_OPTIONS for UMD builds. Also optional: add `settings.react.version = "detect"` to .eslintrc.js to silence eslint-plugin-react warnings.