chore: fix and update prettier and linter rules#9
chore: fix and update prettier and linter rules#9kumar111222rohit wants to merge 1 commit intosanishkr:masterfrom
Conversation
| "prepublish": "npm run pretty && npm run test && npm run build", | ||
| "demo": "webpack-dev-server --inline --hot --config demo/webpack.config.js --content-base demo/", | ||
| "pretty": "prettier --write '{__tests__,src}/*.js'" | ||
| "format": "prettier --write \"{src,__tests__,demo,*.js,*.json,*.md}\"", |
There was a problem hiding this comment.
this still exists in L:15, unpublish
| "build": "babel src/index.js --out-file dist.js", | ||
| "umd": "webpack --config webpack.config.umd.js", | ||
| "lint": "eslint {__tests__,src}/*.js", | ||
| "lint": "eslint .", |
There was a problem hiding this comment.
running npm i with --legacy-peer-deps flag returns error like this:
Please make sure to validate changes locally before creating PR
| quoteProps: 'as-needed', | ||
| trailingComma: 'none', | ||
| tabWidth: 2, | ||
| useTabs: false, | ||
| printWidth: 80, | ||
| endOfLine: 'lf', | ||
| bracketSpacing: true, | ||
| arrowParens: 'avoid', | ||
| jsxSingleQuote: true, | ||
| overrides: [ | ||
| { | ||
| files: '*.json', | ||
| options: { | ||
| printWidth: 200 | ||
| } | ||
| }, | ||
| { | ||
| files: '*.md', | ||
| options: { | ||
| proseWrap: 'always', | ||
| printWidth: 72 | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
not sure why we need all of these rules, pls mention the need and what it does?
| import { createRoot } from 'react-dom/client'; | ||
| import ProgressiveImage from '../src/index.js'; | ||
| import React from 'react' | ||
| import {createRoot} from 'react-dom/client' |
There was a problem hiding this comment.
I would keep the rule to keep spaces in named imports
| }; | ||
| const { image, loading, srcSetData } = this.state; | ||
| const { src, children, noRetry, noLazyLoad } = this.props; | ||
| const { src, children, noLazyLoad } = this.props; |
There was a problem hiding this comment.
This was supposed to be intended feature, check documentation.
Better fix its usage than remove it
| 'error', | ||
| {argsIgnorePattern: '^_', ignoreRestSiblings: true} | ||
| ], | ||
| 'no-console': 'warn', | ||
| 'prefer-const': 'error', | ||
| 'no-var': 'error' | ||
| }, |
There was a problem hiding this comment.
same here: if all of it is needed.
If yes, pls add explaination
| umd/ | ||
| node_modules/ | ||
| coverage/ | ||
| *.min.js | ||
| demo/bundle.js No newline at end of file |
There was a problem hiding this comment.
some of these may not exist in project
2 participants
Uh oh!
There was an error while loading. Please reload this page.