feat(imagetool): display cropped image resolution in hotspot/crop modal#12059
Open
wotan-allfather wants to merge 1 commit intosanity-io:mainfrom
Open
feat(imagetool): display cropped image resolution in hotspot/crop modal#12059wotan-allfather wants to merge 1 commit intosanity-io:mainfrom
wotan-allfather wants to merge 1 commit intosanity-io:mainfrom
Conversation
Closes sanity-io#4337 - Add cropped image dimensions display below the crop tool - Calculate dimensions based on image size and crop values - Add i18n key for the dimensions text
|
@wotan-allfather is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hi @wotan-allfather, and thanks for opening this PR! Could you expand a bit on what the use case for this is? An image may be used across lots of different contexts with various transformations applied, so the actual original pixel values tends to be less relevant for Studio users. But curious to hear why you'd like to have this feature :) |
Author
|
editors want to see if their crop maintains sufficient resolution (for print, large displays, etc). Happy to close if this doesn't fit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4337
Description
What to review
Testing
Notes for release