fix(react): find correct instance for hooks that use config #598
+426
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cngonzalez
force-pushed
the
fix/sdk-530/find-correct-instance-for-hooks-that-use-config
branch
from
3824611 to
3cff168
Compare
cngonzalez
deleted the
fix/sdk-530/find-correct-instance-for-hooks-that-use-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was some crossed wires / oversight in a few hooks, so passing in a
documentHandlewith a specificprojectIdordatasetwouldn't necessarily pull up the correctSanityInstance.This PR fixes that and adds those hooks to the MultiResourceRoute and an e2e test.
What to review
The actual important changes are in the react package -- it's a 2 line change. The rest is just future-proofing :)
Testing
Added e2e tests/
Fun gif