refactor(useLogoSoup): parallelize image loading, use reducer for state#5
Merged
refactor(useLogoSoup): parallelize image loading, use reducer for state#5
Conversation
…state - Replace sequential for loop with Promise.allSettled - Replace 3 independent useState calls with useReducer for atomic state transitions - Fix stale data/error inconsistency when inputs change - Early-exit cancelled tasks after image load to skip measurement work
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Stabilize logos array reference via content comparison to prevent infinite re-render loop - Move logosEqual to utils/normalize - Set NODE_ENV=development in bunfig.toml so React loads dev build with act() support - Fix normalize test import path (src/normalize -> src/utils/normalize) - Replace setTimeout with queueMicrotask in mocks to resolve act() warning - Remove unused imports and dead code from test file - Combine filter().map() into single loop per React best practices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forloop withPromise.allSettledfor parallel image loadinguseStatecalls withuseReducerfor atomic state transitionslogosarray dep via content comparison to prevent infinite re-render loopNODE_ENV=developmentso React loads dev build withact()supportqueueMicrotaskinstead ofsetTimeout) and remove unused code