Skip to content

refactor: fix dangerous default argument #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: fix dangerous default argument #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
122a042
refactor: fix dangerous default argument
deepsource-autofix[bot] Apr 12, 2024
47a8b0f
style: format code with Black
deepsource-autofix[bot] Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 30 additions & 17 deletions manimlib/utils/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,20 @@


def to_camel_case(name):
return "".join([
[c for c in part if c not in string.punctuation + string.whitespace].capitalize()
for part in name.split("_")
])
return "".join(
[
[
c for c in part if c not in string.punctuation + string.whitespace
].capitalize()
for part in name.split("_")
]
)


def initials(name, sep_values=[" ", "_"]):
return "".join([
(s[0] if s else "")
for s in re.split("|".join(sep_values), name)
])
def initials(name, sep_values=None):
if sep_values is None:
sep_values = [" ", "_"]
return "".join([(s[0] if s else "") for s in re.split("|".join(sep_values), name)])


def camel_case_initials(name):
Expand All @@ -37,10 +40,16 @@ def split_string_to_isolate_substrings(full_string, *substrings_to_isolate):
if len(substrings_to_isolate) == 0:
return [full_string]
substring_to_isolate = substrings_to_isolate[0]
all_substrings = list(it.chain(*list(zip(
full_string.split(substring_to_isolate),
it.repeat(substring_to_isolate)
))))
all_substrings = list(
it.chain(
*list(
zip(
full_string.split(substring_to_isolate),
it.repeat(substring_to_isolate),
)
)
)
)
all_substrings.pop(-1)
all_substrings = [s for s in all_substrings if s != ""]
return split_string_list_to_isolate_substrings(
Expand All @@ -53,7 +62,11 @@ def split_string_list_to_isolate_substrings(string_list, *substrings_to_isolate)
Similar to split_string_to_isolate_substrings, but the first argument
is a list of strings, thought of as something already broken up a bit.
"""
return list(it.chain(*[
split_string_to_isolate_substrings(s, *substrings_to_isolate)
for s in string_list
]))
return list(
it.chain(
*[
split_string_to_isolate_substrings(s, *substrings_to_isolate)
for s in string_list
]
)
)