Stricter Handling for DAO::Update function#136
Open
jaagrit10 wants to merge 3 commits intosantanusinha:masterfrom
Open
Stricter Handling for DAO::Update function#136jaagrit10 wants to merge 3 commits intosantanusinha:masterfrom
jaagrit10 wants to merge 3 commits intosantanusinha:masterfrom
Conversation
added 3 commits
April 29, 2025 00:08
sarang4
reviewed
Aug 29, 2025
| try { | ||
| return transactionExecutor.get(tenantId).execute(dao.sessionFactory, | ||
| true, | ||
| "update", |
sarang4
reviewed
Aug 29, 2025
| * @throws IllegalArgumentException If the mutation process fails to create a valid updated entity. | ||
| * @throws RuntimeException If any other error occurs during the update operation. | ||
| */ | ||
| public T updateEntity(String tenantId, String parentKey, DetachedCriteria criteria, |
There was a problem hiding this comment.
add test cases around this function usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mandatory update operation to RelationalDao
This PR adds a new updateEntity() method to RelationalDao that enforces stricter update semantics:
This complements the existing update() method which has more lenient behavior, giving developers choice between strict and permissive update operations.