Skip to content

Commit aff1060

Browse files
authored
fix: unable to delete MCP server from permission settings BerriAI#16124 (BerriAI#16407)
1 parent 0ecc385 commit aff1060

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

ui/litellm-dashboard/src/components/team/team_info.tsx

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -357,23 +357,22 @@ const TeamInfoView: React.FC<TeamInfoProps> = ({
357357
servers: [],
358358
accessGroups: [],
359359
};
360-
const mcpToolPermissions = values.mcp_tool_permissions || {};
361-
362-
if (
363-
(servers && servers.length > 0) ||
364-
(accessGroups && accessGroups.length > 0) ||
365-
Object.keys(mcpToolPermissions).length > 0
366-
) {
367-
updateData.object_permission = {};
368-
if (servers && servers.length > 0) {
369-
updateData.object_permission.mcp_servers = servers;
370-
}
371-
if (accessGroups && accessGroups.length > 0) {
372-
updateData.object_permission.mcp_access_groups = accessGroups;
373-
}
374-
if (Object.keys(mcpToolPermissions).length > 0) {
375-
updateData.object_permission.mcp_tool_permissions = mcpToolPermissions;
376-
}
360+
const serverIds = new Set(servers || []);
361+
const mcpToolPermissions = Object.fromEntries(
362+
Object.entries(values.mcp_tool_permissions || {}).filter(([serverId]) =>
363+
serverIds.has(serverId)
364+
)
365+
);
366+
367+
updateData.object_permission = {};
368+
if (servers) {
369+
updateData.object_permission.mcp_servers = servers;
370+
}
371+
if (accessGroups) {
372+
updateData.object_permission.mcp_access_groups = accessGroups;
373+
}
374+
if (mcpToolPermissions) {
375+
updateData.object_permission.mcp_tool_permissions = mcpToolPermissions;
377376
}
378377
delete values.mcp_servers_and_groups;
379378
delete values.mcp_tool_permissions;

0 commit comments

Comments
 (0)