-
Notifications
You must be signed in to change notification settings - Fork 65
sap_swpm: Improve SUM handling behaviour for slower systems #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
… SUM status checks
berndfinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcelmamula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rob0d Where does this PR fix issue 1139?
This PR only updates task names and hardcodes longer timeout. It does not change any logic for SPAU steps.
There is no issue with any logic for SPAU or any other steps. |
|
@rob0d Then it would mean "Fixes issue #1139" is incorrect, because it did not fix anything. Correct sentence should be: "Improve SUM task names for better readability as discussed in #1139". This is not meant to be pedantic remark, but instead attempt to ensure that other issue is not closed because this PR seemingly fixed it. |
marcelmamula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@berndfinger @rob0d I have removed LGTM reviews because there was commit after reviews were done. Plus this name is not very good |
Oops. That was a mistake. It should have gone to a new PR. Fixing it. |
|
@rob0d Name would be simple |
|
OK. I've now removed the last commit. |
marcelmamula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@rob0d As you say, need an Issue/PR to discuss child Shell Env Var injection use cases and subsequent Ansible code changes 🙂 No worries on the accidental commit, thanks for the quick resolution |
Updated task names to make it clearer that it will look for SPAU or EXIT step.
Changed the time we are waiting for SPAU or EXIT phases to happen to 240*5 minutes = 20 hours
Improve SUM task names for better readability as discussed in #1139