Conversation
… cleanup Improve reliability and error handling in the Network Injection agent's netlink namespace management: - Add isLocked flag tracking to prevent thread lock leaks - Introduce lockThread/unlockThread helper methods for atomic lock state management - Add comprehensive error wrapping throughout netlink operations for better debugging - Implement cleanupFailedNamespace() for proper resource cleanup on failures - Add validation to ensure veth pairs exist even when namespace exists (fixes broken namespace state) - Ensure proper thread unlock on all error paths in EnableNetworkNamespace - Close origin namespace handle in DisableNetworkNamespace to prevent leaks - Add safety checks in Close() to prevent double-close - Refactor DeleteNetworkNamespace to extract deleteNamespace() helper - Fix deferred namespace disable in EnableInjection with proper error logging - Return errors from haproxy.AddInstance instead of swallowing them - Add "fmt" import to openstack.go for error wrapping
Wrap existingNS.Close() in deferred function with blank identifier to properly handle the error return value as per project conventions.
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve reliability and error handling in the Network Injection agent's netlink namespace management: